Francesco Romani has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError ......................................................................
Patch Set 8: Code-Review-1 well, I spoke too early :) _read_password can be a module-private free function. Moreover, right now it lacks the 'self' argument (or @staticmethod, but no need for this) -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan <k...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
