Francesco Romani has posted comments on this change. Change subject: vm: stats: cache metadata value ......................................................................
Patch Set 13: Verified+1 Verification: - I failed to trigger UpdateVmPolicy through Engine, so I used vdsClient - set vcpuLimit to various random values (25, 75, 99) through vdsClient - verified the value is reported in getAllVmStats output - verified the value survives a VDSM restart (simulate recovery flow) - verified with a custom tiny python script that the domain metadata actually contains the expected XML, and that his XML is updated noticed an unrelated formatting bug: after each update, the QoS XML gains a couple of '\n\n' Example: 1. <qos>\n\n<vcpuLimit>20</vcpuLimit>\n</qos> 2. <qos>\n\n\n\n<vcpuLimit>30</vcpuLimit>\n</qos> 3. <qos>\n\n\n\n\n\n<vcpuLimit>30</vcpuLimit>\n</qos> and so on. Will fix with a future patch, should be 1. harmless and 2. unrelated to this patch (which doesn't affect how QOS policy XML is built) -- To view, visit https://gerrit.ovirt.org/37592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
