Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: stats: cache metadata value ......................................................................
vm: stats: cache metadata value vcpuLimit can be set only by Engine (or anyone else impersonating it using the UpdateVmPolicy API). It seems a little wasteful to poll, albeit infrequently (every 15s), for changes in a value which we know when and how it will change. Instead of doing so, this patch adds a simple cache variable, to be transparently updated after each UpdateVmPolicy. Please note that the same approach was taken for I/O tune, based on the assumption that VDSM is the only controller of libvirt. Since this assumption is ingrained in the very roots of how VDSM works, it seem fair to extend to (V)CPU tune as well. Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/37592 Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/vmTests.py M vdsm/virt/vm.py 2 files changed, 38 insertions(+), 48 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/37592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
