Shahar Havivi has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/37509/8/vdsm/v2v.py File vdsm/v2v.py: Line 114: return {'status': doneCode} Line 115: elif _jobs[jobId].status != _STATUS_DONE: Line 116: return errCode['V2VJobNotDone'] Line 117: else: Line 118: del _jobs[jobId] > Do you mean that get_converted_vm will return success and no ovf? Yes but I did change it and will be available in the next patch. This verb will only return ovf or error. a new verb that will delete the ovf (in case of errors too) which the engine will call after getting the ovf as you suggested Line 119: Line 120: try: Line 121: file_name = os.path.join(_P_V2V_DIR, "%s.ovf" % jobId) Line 122: with open(file_name, 'r') as f: Line 127: return errCode['invalidV2VOvfPath'] Line 128: else: Line 129: logging.error('error reading file "%s" error: %r message %r', Line 130: file_name, exc.errno, exc.message) Line 131: raise > Right, the method should not return an error, this belongs to the public fu Yes I am working on that now as in comments in version #9 Line 132: return {'status': doneCode, 'ovf': ovf} Line 133: Line 134: Line 135: def abort_job(jobId): -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
