Nir Soffer has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/37509/9/vdsm/v2v.py File vdsm/v2v.py: Line 179: self._vmProperties = vmProperties Line 180: self._job_id = jobId Line 181: self._cif = cif Line 182: self._status = _STATUS_INITIALIZING Line 183: self._progress = 0 > Thats what I present for next patch A progress can start in indeterminate mode, where you don't know yet the total amount of work. In this state, the can show a progress bar with some animation. When you collected the data, you can switch to normal mode, where you show a progress bar from 0% to 100%. See https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/ProgIndic/Concepts/AboutProgIndic.html#//apple_ref/doc/uid/20000111-BCIECBIG This is of course Mac OS X behavior, but in the recent years, more users expect this. Line 184: self._abort = False Line 185: self._status_msg = '' Line 186: Line 187: def start(self): -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
