Michal Skrivanek has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37509/8/vdsm/v2v.py File vdsm/v2v.py: Line 120: try: Line 121: file_name = os.path.join(_P_V2V_DIR, "%s.ovf" % jobId) Line 122: with open(file_name, 'r') as f: Line 123: ovf = f.read() Line 124: os.remove(file_name) > in this case (which is right) I'm fine with aborting in case of disconnect and wiping out the fully converted disk and ovf. Disconnects should not happen and it's not interesting to handle partially successful cases Line 125: except IOError as exc: Line 126: if exc.errno == errno.ENOENT: Line 127: return errCode['invalidV2VOvfPath'] Line 128: else: -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
