Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 2: (3 comments) a few questions inside https://gerrit.ovirt.org/#/c/40103/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 387: def VM_getMigrationStatus_Ret(ret): Line 388: """ Line 389: Return status of the Migration, progress and downtime if available Line 390: """ Line 391: return ret why do we need this? looks like a simple passthrough, IIRC can be avoided Line 392: Line 393: Line 394: def Volume_getsize_Ret(ret): Line 395: """ https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1717: 'network': {}, Line 1718: 'disks': {}} Line 1719: if 'pauseCode' in self.conf: Line 1720: stats['pauseCode'] = self.conf['pauseCode'] Line 1721: if self.isMigrating() and self.migrateStatus().has_key('progress'): why is this needed? Line 1722: stats['migrationProgress'] = self.migrateStatus()['progress'] Line 1723: Line 1724: decStats = {} Line 1725: try: Line 1866: return self._migrationSourceThread.status Line 1867: finally: Line 1868: self._guestCpuLock.release() Line 1869: Line 1870: def migrateStatus(self): Can't we just always use the new downtime_net? Line 1871: return self._migrationSourceThread.getStat(useDowntime=True) Line 1872: Line 1873: def migrateCancel(self): Line 1874: self._acquireCpuLockWithTimeout() -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
