Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40103/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1717: 'network': {}, Line 1718: 'disks': {}} Line 1719: if 'pauseCode' in self.conf: Line 1720: stats['pauseCode'] = self.conf['pauseCode'] Line 1721: if self.isMigrating() and self.migrateStatus().has_key('progress'): > There is not always progress and we had NPE when calling migrateStat verb. I'd say it should always have a progress when isMigrating() what NPE you get? There should have been an exception here on vdsm side Line 1722: stats['migrationProgress'] = self.migrateStatus()['progress'] Line 1723: Line 1724: decStats = {} Line 1725: try: -- To view, visit https://gerrit.ovirt.org/40103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
