Hey,
I suggest we start unifying in a couple of days indeed. I still have a
couple of things to merge, essentially having GEMM dynamically generated
for some cases and publishing the repo for auto-tuning using pyviennacl.
These have to be done soon so that Toby can present some good benchmarks at
the talk.
As for namespaces, this is a difficult questions. I tend to prefer
unindented namespaces. Since each file usually works on a single namespace,
having an indent there creates a global offset. As for the level of
nestedness, i have rarely found it to be a useful piece of information.
Plus, ViennaCL often uses 3 -4 nested namespace, and a constant offset of
6-8 spaces can be bothersome on a laptop (considering that we also have
class + function offsets).
Philippe
2014-07-03 23:27 GMT+02:00 Karl Rupp <r...@iue.tuwien.ac.at>:
> Hi guys,
>
> about a year ago we (i.e. the main Vienna* developers) had a discussion
> regarding a common coding style. Finally, everything is available online
> on a wiki page:
> http://viennastar.iue.tuwien.ac.at/wiki/doku.php?id=codingstyle
>
> Philippe and I will go through the code base in the next couple of days
> and unify things as much as possible (and reasonable), touching a lot of
> code lines. One thing that is not yet specified (and which should
> probably be decided on a per-project basis) is the handling of
> namespaces. My personal preference is indenting:
>
> namespace viennacl
> {
> namespace linalg
> {
> ...
> }
> }
>
> whereas the non-indented alternatives, e.g.:
>
> namespace viennacl {
> namespace linalg {
> ...
> }
> }
>
> also have their advantages. Still, the indented version is the one which
> is most consistent with the indenting of classes, functions, etc.
> Although it potentially leads to larger commits if a function is moved
> in or out of a nested namespace, I'm still in very mild favor of
> indenting, because I can quickly get an overview of the level of
> nestedness when scrolling over the code.
>
> @all, but mostly @Philippe: what are your thoughts?
>
> Best regards,
> Karli
>
>
> ------------------------------------------------------------------------------
> Open source business process management suite built on Java and Eclipse
> Turn processes into business applications with Bonita BPM Community Edition
> Quickly connect people, data, and systems into organized workflows
> Winner of BOSSIE, CODIE, OW2 and Gartner awards
> http://p.sf.net/sfu/Bonitasoft
> _______________________________________________
> ViennaCL-devel mailing list
> ViennaCL-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/viennacl-devel
>
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
ViennaCL-devel mailing list
ViennaCL-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viennacl-devel
