Hi,
> I suggest we start unifying in a couple of days indeed. I still have a
> couple of things to merge, essentially having GEMM dynamically generated
> for some cases and publishing the repo for auto-tuning using pyviennacl.
> These have to be done soon so that Toby can present some good benchmarks
> at the talk.
Perfect, then I'll finalize the new sparse matrix format in the meanwhile.
> As for namespaces, this is a difficult questions. I tend to prefer
> unindented namespaces. Since each file usually works on a single
> namespace,
implementation helpers should be put in a detail-namespace, so that it
is also clear documentation-wise which functions are part of the public
API and which are not. There's some cleanup-work necessary. This
naturally induces a separation of a file into 'detail' implementations,
and public API functions, which can be visually distinguished by the indent.
> having an indent there creates a global offset. As for the
> level of nestedness, i have rarely found it to be a useful piece of
> information. Plus, ViennaCL often uses 3 -4 nested namespace, and a
> constant offset of 6-8 spaces can be bothersome on a laptop (considering
> that we also have class + function offsets).
These are all valid points. What about cropping this 'offset' and use
something like the following:
namespace viennacl { namespace linalg {
void some_api_function() { ... }
namespace detail
{
void some_implementation_detail() { ... }
}
}}
This would preserve the benefit of a visual separation of public API and
private implementations, yet remove the 'global' indent offset from the
source file.
Best regards,
Karli
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
ViennaCL-devel mailing list
ViennaCL-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viennacl-devel
