Hi Bram!

On Mo, 15 Feb 2016, Bram Moolenaar wrote:

> 
> Mike Williams wrote:
> 
> > On 15/02/2016 08:10, Axel Bender wrote:
> > > Compiling vim.exe (Windows 7 64-bit, MinGW 64-bit) fails with:
> > >
> > > gcc -c -Iproto -DWIN32 -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 
> > > -DHAVE_PATHDEF -DFEAT_BIG -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H 
> > > -DDYNAMIC_GETTEXT -DFEAT_OLE -DFEAT_CSCOPE -DFEAT_MBYTE -DFEA
> > > T_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -w -march=x86-64 -Wall 
> > > -Id:/tools/perl/lib/Core -DFEAT_PERL -DPERL_IMPLICIT_CONTEXT 
> > > -DPERL_IMPLICIT_SYS -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"pe
> > > rl522.dll\" -DFEAT_PYTHON -DDYNAMIC_PYTHON 
> > > -DDYNAMIC_PYTHON_DLL=\"python27.dll\" -O3 -fomit-frame-pointer 
> > > -freg-struct-return -s os_win32.c -o objx86-64/os_win32.o
> > > os_win32.c: In function 'mch_start_job':
> > > os_win32.c:5102:1: error: label at end of compound statement
> > >   failed:
> > >   ^
> > > Make_cyg_ming.mak:852: recipe for target 'objx86-64/os_win32.o' failed
> > > make: *** [objx86-64/os_win32.o] Error 1
> > >
> > 
> > diff --git a/src/os_win32.c b/src/os_win32.c
> > --- a/src/os_win32.c
> > +++ b/src/os_win32.c
> > @@ -5101,8 +5101,9 @@ mch_start_job(char *cmd, job_T *job)
> > 
> >   failed:
> >   # ifdef FEAT_CHANNEL
> > -    channel_free(channel);
> > +    channel_free(channel)
> >   # endif
> > +  ;
> >   }
> > 
> > 
> > Come on guys, if you're fixing code dependent on pp defines, check with 
> > them both defined and undefined that everything still builds and links.
> 
> It appears Appveyor only builds one specific setup.  It would be useful
> to run a few more combinations.  I can't possibly check more than a few
> things, especially if it involves MS-Windows (with at least four
> combinations: GUI/console * MSVC/MingW).

We test building 32 and 64bit vim.exe when creating the 
vim-win32-installer once a day. We could possibly add more features 
using a matrix. But I think it makes sense to test this using the 
regular appveyor tests. What features should we add there for testing?


Best,
Christian
-- 
Die Aläutischen Inseln wohnen in Erdhütten. Ihre Fenster sind oben; eigentlich 
haben
sie gar keine Fenster.
                -- Johann Georg August Galletti

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui