Hi Christian,
2016/2/17 Wed 17:35:20 UTC+9 Christian Brabandt wrote:
> Hi Bram!
>
> On Mo, 15 Feb 2016, Bram Moolenaar wrote:
>
> > This should not be part of the daily build but the one that's triggered
> > by a submit. Then we get a warning email five minutes later.
>
> That's what I meant.
>
> >
> > The one we currently have only tests the GUI. We should at least have
> > one that builds the console version.
> >
> > Also having at least one for MingW seems necessary, since it produces
> > different warnings and errors than MSVC.
> >
> > We'll never catch everything, but we can try to catch the most common
> > problems. So long as we don't run out of capacity on Appveyor.
>
> Okay, here we go. This builds MVC (64bit) and mingw 32bit versions on
> appveyor with all feature switches (gvim and vim.exe). The huge versions
> is build with python enabled. This should catch most of the obvious
> #ifdef errors we have seen lately.
>
> The patch already contains some #ifdefs, needed to fix some errors.
> Unfortunately, I haven't seen it build completely yet, due to some
> errors and the current fast development cycle.
>
> Some of the errors and warnings reported here on the list are also shown
> in the current logs, e.g.
> https://ci.appveyor.com/project/chrisbra/vim-ch0ci/build/job/ag948fmsdkuv4dok#L307
> https://ci.appveyor.com/project/chrisbra/vim-ch0ci/build/job/ag948fmsdkuv4dok#L344
> https://ci.appveyor.com/project/chrisbra/vim-ch0ci/build/job/ag948fmsdkuv4dok#L362
> https://ci.appveyor.com/project/chrisbra/vim-ch0ci/build/job/ag948fmsdkuv4dok#L397
> https://ci.appveyor.com/project/chrisbra/vim-ch0ci/build/job/ag948fmsdkuv4dok#L438
>
> However, since this builds MSVC and Mingw gvim and vim.exe for
> FEATURES=tiny, small, normal, big and huge and runs the test it will
> take a while to finish, probably around 50 Minutes.
>
> Feedback appreciated.
I don't think the following hunk should be applied:
--- a/src/os_win32.c
+++ b/src/os_win32.c
@@ -5175,8 +5175,10 @@ mch_stop_job(job_T *job, char_u *how)
return TerminateProcess(job->jv_proc_info.hProcess, 0) ? OK : FAIL;
}
+#ifndef __MINGW32__
if (!AttachConsole(job->jv_proc_info.dwProcessId))
return FAIL;
+#endif
ret = GenerateConsoleCtrlEvent(
ctrl_c ? CTRL_C_EVENT : CTRL_BREAK_EVENT,
job->jv_proc_info.dwProcessId)
MinGW is too old now. We should use MinGW-w64 (MSYS2) instead.
MinGW-w64 is available on the following path on AppVeyor:
32 bit target: C:\msys64\mingw32\bin
64 bit target: C:\msys64\mingw64\bin
Regards,
Ken Takata
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
