2016-04-28 4:47 GMT+09:00 Bram Moolenaar <b...@moolenaar.net>:
>
> Kazunobu Kuriyama wrote:
>
> > 2016-04-28 0:42 GMT+09:00 Bram Moolenaar <b...@moolenaar.net>:
> >
> > >
> > > Kazunobu Kuriyama wrote:
> > >
> > > > 2016-04-27 17:51 GMT+09:00 Bram Moolenaar <b...@moolenaar.net>:
> > > >
> > > > >
> > > > > Christian Brabandt wrote:
> > > > >
> > > > > > Am 2016-04-26 19:01, schrieb Bram Moolenaar:
> > > > > > > Patch 7.4.1789
> > > > > >
> > > > > > I think this patch broke the vim-win32-installer build
> > > > > >
> > > > > > From test_channel.vim:
> > > > > > Found errors in Test_out_close_cb():
> > > > > > function RunTheTest[9]..Test_out_close_cb line 23: Expected 1 but
> > > got 2
> > > > > > function RunTheTest[9]..Test_out_close_cb line 24: Expected 2 but
> > > got 3
> > > > > > TEST FAILURE
> > > > > > NMAKE : fatal error U1077: 'if' : return code '0x1'
> > > > > > Stop.
> > > > > > Command exited with code 1
> > > > > >
> > > > > >
> > > > >
> > >
> https://ci.appveyor.com/project/chrisbra/vim-win32-installer/build/94/job/ah9t0xb7hkh14ous
> > > > >
> > > > > I noticed the travis build also failed with this error, but then
> passed
> > > > > later. For me it always passes, thus it's hard to find out why it
> > > would
> > > > > sometimes fail. It looks like the callback is invoked twice, but I
> > > > > don't know why/when that happens. Any idea?
> > > > >
> > > >
> > > > On OS X, the same error happens occasionally.
> > > >
> > > > Since it didn't always happen, I had put it on probation and
> refrained
> > > from
> > > > accusing it of the failure. :)
> > > >
> > > > Having done 'make test' five or six times with ch_logfile of
> > > > test_channel.vim enabled, I finally caught it.
> > > >
> > > > Attached are the waring message of the failure (warning.txt) and
> > > > testdir/channellog when it happened.
> > > >
> > > > Hopefully, this could be helpful for you.
> > >
> > > Unfortunately the channellog is truncated before the interesting part.
> > > Perhaps you can start the log in the Test_out_close_cb function.
> > >
> >
> > I added call
> >
> > ch_log('Test_out_close_cb()')
> >
> > just after test_channel.vim:1055, and the attached file is the result.
>
> That line was already there. do you mean you added ch_logfile()?
>
Exactly. More precisely,
diff --git a/src/testdir/test_channel.vim b/src/testdir/test_channel.vim
index 6eb3c1f..1e6db68 100644
--- a/src/testdir/test_channel.vim
+++ b/src/testdir/test_channel.vim
@@ -1052,6 +1052,7 @@ func Test_out_close_cb()
if !has('job')
return
endif
+ call ch_logfile('channellog', 'w')
call ch_log('Test_out_close_cb()')
let s:counter = 1
> > Does this contain the part you need?
>
> This is what I see:
>
> ==== start log session ====
> 0.000015 : Test_out_close_cb()
> 0.000114 : Starting job: python test_channel_pipe.py quit now
> 0.000148 on 26: Created channel
> 0.012371 ERR on 25: channel_select_check(): Cannot read from
> channel
> 0.012463 on 25: Closing channel
>
> 25 is from the previous test, we can ignore that.
>
> 0.012479 : looking for messages on channels
> 0.038454 RECV on 26: 'quit
> '
> 0.038475 on 26: Invoking channel callback OutHandler
>
> First call to OutHandler
>
> 0.049656 ERR on 26: channel_select_check(): Cannot read from
> channel
> 0.049742 PUT on 26: 'DETACH
> '
> 0.049750 on 26: Closing channel
> 0.049805 on 26: Invoking channel callback OutHandler
>
> Second call to OutHandler
>
> 0.049953 on 26: Invoking close callback CloseHandler
>
> Hmm, it does appear to call OutHandler twice.
> In my case the first call isn't there.
> I suppose what happens is that the DETACH is received separately.
> That is actually what should happen, so why is that message dropped in
> my case? Requires some more debugging...
>
If you need more experiments, or something I can do for you, let me know.
>
> --
> ARTHUR: Charge!
> [They all charge with swords drawn towards the RABBIT. A tremendous
> twenty
> second fight with Peckinpahish shots and borrowing heavily also on the
> Kung Fu and karate-type films ensues, in which some four KNIGHTS are
> comprehensively killed.]
> ARTHUR: Run away! Run away!
> "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES
> LTD
>
> /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net
> \\\
> /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/
> \\\
> \\\ an exciting new programming language -- http://www.Zimbu.org
> ///
> \\\ help me help AIDS victims -- http://ICCF-Holland.org
> ///
>
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
