Re: [PATCH] a bit more M::B help for VMS

[John E. Malmberg]

Craig A. Berry wrote:
At 7:56 PM -0500 3/24/06, John E. Malmberg wrote:

Extutils/CBuilder/Platform/VMS.pm still needs some work,
 
Urk.  Does this do any good?

--- lib/ExtUtils/CBuilder/Platform/VMS.pm;-0    Fri Mar 17 07:20:09 2006
+++ lib/ExtUtils/CBuilder/Platform/VMS.pm       Fri Mar 24 18:59:37 2006
@@ -21,10 +21,13 @@ sub arg_defines {
     $config_defines = $1;
   }
 
-  return unless (scalar keys %args) || $config_defines;
+  my $have_arg_defines = scalar keys %args;
+  return unless $have_arg_defines || $config_defines;
+
+  my $comma = $have_arg_defines ? ',' : '';
 
   return ('/define=('
-          . (defined $config_defines ? "$config_defines," : '')
+          . (defined $config_defines ? "$config_defines$comma" : '')
           . join(',',
                  map "\"$_" . ( length($args{$_}) ? "=$args{$_}" : '') . "\"",
                      keys %args)
[end of patch]

Both lib/ExtUtils/CBuilder/t/01-basic.t and 
lib/ExtUtils/CBuilder/t/02-link both pass with that.

-John
[EMAIL PROTECTED]
Personal Opinion Only