On 23 January 2015 at 07:59, Tapani Pälli <tapani.pa...@intel.com> wrote: > Patch fills attributes table suitable for Pepper API from > wcore_config_attrs passed by the application. > > Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> > --- > src/waffle/nacl/nacl_config.c | 30 ++++++++++++++++++++++++++++++ > src/waffle/nacl/nacl_config.h | 2 ++ > 2 files changed, 32 insertions(+) [...] > diff --git a/src/waffle/nacl/nacl_config.h b/src/waffle/nacl/nacl_config.h > index 3270179..ff73e6c 100644 > --- a/src/waffle/nacl/nacl_config.h > +++ b/src/waffle/nacl/nacl_config.h > @@ -27,12 +27,14 @@ > > #include "wcore_config.h" > #include "wcore_util.h" > +#include "ppapi/c/pp_graphics_3d.h" > Bikeshed: you might want to move where it's used - nacl_config.c
> struct wcore_config_attrs; > struct wcore_platform; > > struct nacl_config { > struct wcore_config wcore; > + int32_t attribs[64]; Currently you're using 22 of those. Adding a note next to the PUSH_ATTRIB macro (attribs is of fixed size) will likely save some future headaches :-) -Emil _______________________________________________ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle