The -Werror failure I saw was when compiling the generated proto files.
I would imagine that a newer version of protoc would produce slightly
different generated java which doesn't result in compiler warnings.
I noticed with your maven build that you re-generate those files every
build - where the current tree has them checked in.
It'd be worth trying to generate them with latest protoc to see if that
avoids the problem.
Dave
On 31/05/13 16:35, Paulo Pires wrote:
With Maven, I only had an issue (with source as 1.7, because 1.6 works nicely)
that I fixed with
https://github.com/pires/wave/commit/34e44e1dfb0ac6e7820f4d4b71fe05837efed960
On May 31, 2013, at 4:09 PM, Pratik Paranjape <[email protected]> wrote:
Got it to compile and run on Ubuntu 12.10/Oracle JDK7 with following fixes:
1) Changed non-static references to a static method into references by
Class name
2) Relaxed visibility of members from private to protected in
AbstractTreeNode.java
3) Removed -Werror flag from build-macros.xml
4) There were test ERRORS, ignored. Couple of test failures, ignored.
To make it easy for new people, I suggest:
1) remove -werror flag
2) remove test as required step for dist during build
We can raise issues for both of these to be solved separately, because its
not going to be a short solution. We can move
on to adding/changing features. Build and test failures for new people can
be discouraging.
Is there an objection on removing -werror flag altogether? Most of them are
going to have JDK7 now and solving for
2000 odd warnings is not going to be easy. Many of those are about not
parametarizing a raw type.
Regards,
- Pratik
