Excellent suggestion on adding the comments with a link to the discussion thread Iceberg
-Thadeus On Sat, Jan 30, 2010 at 2:07 AM, Iceberg <iceb...@21cn.com> wrote: > When saying "some people ask for zero=None, some for zero='', some for > zero='Please choose a value'", ok, I am the one who once suggest the > recent zero='' change, in this thread: > https://groups.google.com/group/web2py/browse_frm/thread/7a5154c377c9eec3 > > But hey, I think I made myself clear in that post, that: > zero='blah blah' is UNACCEPTABLE, because it is not friendly for non- > english users. > zero='' is better than above > zero=None is preferable. The reason is explained so well by Denes > and Thadeus, and I can't agree more. > > And one more suggestion. If after this discussion, the default zero is > back to None again (I hope so), so please please add one line of > comment as a warning sign, to avoid it being change in the future. It > was changed back and forth in the past, only because we fail to mark > all these valuable, wise discussion in document. For example: > > IS_IN_DB(..., > zero=None, # Why? See > https://groups.google.com/group/web2py/browse_frm/thread/d25d13cd3f5bd7b1 > ...) > > Regards, > Iceberg > > On Jan29, 11:55pm, Thadeus Burgess <thade...@thadeusb.com> wrote: >> +1 supporting DenesL argument. (but we already know this) >> >> note. >> >> default. >> >> breaks app. >> >> we like the feature >> >> but it shouldn't break an app >> >> no reason to have to specifically DISABLE something that hasn't >> existed in web2py before ( you know, the empty select or "please >> choose a value" breaks my app which is why I'm still running pre-1.70 >> codebase ) >> >> The only reason that it defaults to zero='' is because the person who >> originally requested it needed that. >> >> Their only argument was THEY needed it so it should default to it just >> for THEIR convenience while everyone else is subjugated to having to >> DISABLE a NEW feature. >> >> -Thadeus >> >> >> >> On Fri, Jan 29, 2010 at 9:31 AM, DenesL <denes1...@yahoo.ca> wrote: >> >> > I must insist. >> > The point is that IS_IN_DB and IS_IN_SET now show a spurious empty >> > option by default. >> > The keyword here is default. >> >> > If you want to introduce a 'choose a value" option you should do it >> > explicitly and 'at your own risk', the risk being that it creates an >> > option that when selected will cause an error. >> >> > An empty option is plainly wrong, it is not part of the IS_IN_DB or >> > IS_IN_SET options. It is completely artificial. >> >> > How many times the option has been changed should not matter, getting >> > it right should. >> > Denes. >> >> > On Jan 29, 10:06 am, mdipierro <mdipie...@cs.depaul.edu> wrote: >> >> There is no way to please everybody here. some people ask for >> >> zero=None, some for zero='', some for zero='Please choose a value'. >> >> There is no right or wrong. I think we should leave the default as is >> >> ('', we changed it twice already) and you configure it as needed. >> >> >> Massimo >> >> >> On Jan 29, 9:00 am, DenesL <denes1...@yahoo.ca> wrote: >> >> >> > <bump> >> >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "web2py-users" group. >> > To post to this group, send email to web...@googlegroups.com. >> > To unsubscribe from this group, send email to >> > web2py+unsubscr...@googlegroups.com. >> > For more options, visit this group >> > athttp://groups.google.com/group/web2py?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "web2py-users" group. > To post to this group, send email to web...@googlegroups.com. > To unsubscribe from this group, send email to > web2py+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/web2py?hl=en. > > -- You received this message because you are subscribed to the Google Groups "web2py-users" group. To post to this group, send email to web...@googlegroups.com. To unsubscribe from this group, send email to web2py+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/web2py?hl=en.
