On Apr 19, 2010, at 5:05 PM, mdipierro wrote:

>> Why does the compiled version include the .pyc files in controllers/ 
>> (outside of compiled/)? It doesn't seem like those get used, at least not by 
>> run_controller_in.
> 
> I think you refer to line 298 of compileapp.py. I do not recall why it
> is there. I will try remove it and see what breaks.

Ah, yes, that's where it comes from.

> 
>> And a minor thing: there's a lot of this kind of thing:
>> 
>>     path = os.path.join(folder, 'compiled/')
>> 
>> Should the '/' really be part of the call? It sort of defeats the purpose of 
>> os.path.join.
> 
> There are a few cases when in can be removed (and I just did in trunk)
> but most of them are required else listdir does not work properly.

listdir appends a '/' if there isn't one already. (Though I don't see why it 
needs to, as long as it computes n correctly.)

BTW, the comment for listdir seems to confuse add_dirs with drop. Or something. 
And a pair of typos: s/b "regex pattern to filter files"

-- 
Subscription settings: http://groups.google.com/group/web2py/subscribe?hl=en

Reply via email to