Can you explain the consequences of this line in your patch?

if (jQuery(document).width() >= 980) 

On Friday, 10 August 2012 10:11:39 UTC-5, AngeloC wrote:
>
> Hi Massimo,
>
> I fixed compatibility with IE and reverted to a non mobile first approach. 
> I reverted because bootstrap is not mobile first (so we add too little) and 
>  for the sake of compatibility with IE.
>
> Patch is attached to issue 
> http://code.google.com/p/web2py/issues/detail?id=896 which I cannot 
> reopen.
>
> Hope this helps!
>
> Angelo
>
> 2012/8/10 Angelo Compagnucci <angelo.co...@gmail.com <javascript:>>
>
>> Hi Massimo,
>>
>> I'm writing it right now to fix ie issues! Please be patient until fixed!
>>
>>
>> 2012/8/9 Massimo Di Pierro <massimo....@gmail.com <javascript:>>
>>
>>> This may be ok but where do I get bootswatch_ie.css from?
>>>
>>>
>>> On Thursday, 9 August 2012 11:43:28 UTC-5, AngeloC wrote:
>>>
>>>> Hi Massimo,
>>>>
>>>> I think I cannot complete the bootstrap/web2py css merging in time for 
>>>> 2.0, it's really a lot of work and I'm a bit busy these days.
>>>>
>>>> Btw, i'm fixing the bug I introduced with issue 896 and I want to share 
>>>> a thought with you.
>>>>
>>>> Actually, there is no way to maintain a mobile first approach and make 
>>>> it working on IE other than add something like this to the scaffolding:
>>>>
>>>> <!-- Makes bootswatch working on IE 7/8 -->
>>>> <!--[if (lt IE 9)]>
>>>> <link rel="stylesheet" href="/responsivekit/static/**
>>>> css/bootswatch_ie.css">
>>>> <![endif]-->
>>>>
>>>> This will make speedier the whole css on not IE browsers because we 
>>>> remove IE specific rules (smaller css), but has the downside to require an 
>>>> extra http get on IE.
>>>>
>>>> What do you think?
>>>>
>>>>
>>>> 2012/8/9 Alec Taylor <alec.t...@gmail.com>
>>>>
>>>>> It would be good to have OAuth working for web2py 2
>>>>>
>>>>> Facebook and LinkedIn still have some issues
>>>>>
>>>>> LinkedIn: https://groups.google.com/**forum/#!topic/web2py/**
>>>>> SbnQEnXEcOg<https://groups.google.com/forum/#!topic/web2py/SbnQEnXEcOg>
>>>>>
>>>>> Facebook: (will add bug report once I've gotten LinkedIn login to work)
>>>>>
>>>>> On Thu, Aug 9, 2012 at 11:25 PM, Massimo Di Pierro
>>>>> <massimo....@gmail.com> wrote:
>>>>> > Can you help us fix the CSS?
>>>>> >
>>>>> >
>>>>> > On Thursday, 9 August 2012 00:29:58 UTC-5, Andrew wrote:
>>>>> >>
>>>>> >> Just a note on IE7 navbar behaviour:
>>>>> >>
>>>>> >> The Menu has taken a turn for the worse:
>>>>> >> Initially the Welcome App Sub Menus dissapeared in :  "welcome css 
>>>>> pathc,
>>>>> >> issue 896, thanks Angelo"
>>>>> >> They then returned in "fixed issue qith clicking on toplevel menus" 
>>>>> except
>>>>> >> all of the submenus are displayed when the menu first appears and 
>>>>> they are
>>>>> >> all on top of each other.
>>>>> >>
>>>>> >> The login options are still blue, and the space between the navbar 
>>>>> and
>>>>> >> "Welcome" isn't there.
>>>>> >> See screen shot.
>>>>> >>
>>>>> >>
>>>>> >> On Thursday, August 9, 2012 9:17:17 AM UTC+12, Massimo Di Pierro 
>>>>> wrote:
>>>>> >>>
>>>>> >>> more issues have been addressed. In order to fix an issue I had to
>>>>> >>> introduce a slight change of behavior and I am not sure what is 
>>>>> the best way
>>>>> >>> to handle it.
>>>>> >>>
>>>>> >>> If you login using a third party service (for example janrain using
>>>>> >>> facebook) and the service sends info about you, if web2py has 
>>>>> corresponding
>>>>> >>> fields in auth_user, it stores them. If you edit your profile, 
>>>>> logout,
>>>>> >>> change your facebook profile, login again using janrain, should 
>>>>> web2py keep
>>>>> >>> the current local profile or update it? The bug report suggested 
>>>>> that web2oy
>>>>> >>> should always give preference to the local profile.
>>>>> >>>
>>>>> >>> I changed web2py accordingly. In practice this change will 
>>>>> probably not
>>>>> >>> affect anybody because none of the services sends any information 
>>>>> stored by
>>>>> >>> auth_user.
>>>>> >>>
>>>>> >>> Yet, please check it.
>>>>> >>>
>>>>> >>> Massimo
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>> On Monday, 6 August 2012 23:33:48 UTC-5, Massimo Di Pierro wrote:
>>>>> >>>>
>>>>> >>>> Web2py 2.0 is almost done.
>>>>> >>>> Please try the nightly build.
>>>>> >>>> Let us know if it breaks anything.
>>>>> >>>>
>>>>> >>>> massimo
>>>>> >
>>>>> > --
>>>>> >
>>>>> >
>>>>> >
>>>>>
>>>>> --
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> -- 
>>>> Profile: 
>>>> http://it.linkedin.com/in/**compagnucciangelo<http://it.linkedin.com/in/compagnucciangelo>
>>>>  
>>>  -- 
>>>  
>>>  
>>>  
>>>
>>
>>
>>
>> -- 
>> Profile: http://it.linkedin.com/in/compagnucciangelo
>>  
>
>
>
> -- 
> Profile: http://it.linkedin.com/in/compagnucciangelo
>  

-- 



Reply via email to