Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 92852ca67fc49280ddb699b7563c952ccc793c97
https://github.com/WebKit/WebKit/commit/92852ca67fc49280ddb699b7563c952ccc793c97
Author: Zak Ridouh <[email protected]>
Date: 2026-10-13 (Tue, 13 Oct 2026)
Changed paths:
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] [macOS] The candidate list and Writing Tools affordance are
displaced in cross-site iframes
https://bugs.webkit.org/show_bug.cgi?id=325632
rdar://188684249
Reviewed by Alex Christensen.
The macOS editor state's selection bounding rect was computed with
contentsToWindow(), which stops at
the local root, so for a selection in a cross-site iframe it was relative to
the iframe. The candidate
list, Writing Tools, and other native UI anchored to that rect were offset by
the iframe's position.
Compute the rect with contentsToMainFrameView() instead.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getPlatformEditorState const):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::TEST(SiteIsolation, CandidateRectInCrossOriginIframe)):
Canonical link: https://commits.webkit.org/323649@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
