On Fri, Aug 7, 2009 at 3:37 PM, Joe Mason <joe.ma...@torchmobile.com> wrote:
> Adam Treat wrote: > >> On Friday 07 August 2009 05:51:57 pm Eric Seidel wrote: >> >>> We also definitely need to fix our tools to make it impossible to post a >>> patch w/o a ChangeLog, and impossible to post a patch that doesn't pass >>> check-webkit-style. >>> >> >> This is a bad idea. check-webkit-style still has false positives and is >> very new. It has been designed to never be free of false positives in fact. >> > > Not to mention there will always be places where human judgement overrides > the guidelines. Also, sometimes a patch is being posted not to be submitted, but to share code to get early feedback on something. Requiring no style lint errors for that use case seems overly restrictive. > > Joe > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev