I didn't know that failing tests would block the commit queue. I saw they were
failing yesterday afternoon and I thought it was ok to wait until this morning
to fix them.
My apologies for the inconvenience.
I believe a reasonable approach to handle these situations is to try to contact
the person responsible for braking the tests in IRC and if there is no response
within an hour, roll back.
I believe that requiring everyone to run the layout tests (the entire suite)
before committing is the right thing to do.
The only time I haven't done it was yesterday :-(.
Lesson learned.
Enrica
On Feb 26, 2010, at 10:15 AM, Jeremy Orlow wrote:
> On Fri, Feb 26, 2010 at 7:06 PM, Maciej Stachowiak <m...@apple.com> wrote:
>
> On Feb 26, 2010, at 9:56 AM, Alexey Proskuryakov wrote:
>
>
> On 26.02.2010, at 9:29, Maciej Stachowiak wrote:
>
> I'd like it if we had an IRC bot that announced build breakage on #webkit.
>
>
> Perhaps better yet, on #webkit-build, as buildbot used to do.
>
> In the past, no one ever joined #webkit-build so this was not an effective
> means of notification.
>
> I didn't even know it existed until now. Was there ever an email sent out on
> this? If so, I missed it.
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
