A few comments: General:
You have added both CR's to the checkin comments to all files. I think maybe the one for DTrace should be applied only to those few files actually touched by this CR. usr/src/Targetdirs: Near your addition you have modified the line with /etc/sane.d, apparently replacing a tab with a space. I suggest you don't do that to avoid having an "artificial" change. usr/src/cmd/mysql-5-1/Makefile.sfw: MYSQL_VERSION could have been split into a MAJOR part (which would be fixed at "5.1" and could be referred to when used in paths) and a MINOR part which could later be updated. But I wouldn't insist on it... I see you use ksh93 for the install scripts (which won't work in sh), but do you also need to run ./configure through ksh? I see both of the above have been coped from the 5.0 Makefile.sfw. usr/src/cmd/mysql-5-1/Solaris/mysql_51.1.sunman Should this really refer to the minor version number? I don't think man pages usually do that (and the ones we include with PopstgreSQL don't). -- Bjorn Munch Sun Microsystems Trondheim, Norway http://sun.com/postgresql/
