Hi Basant,
Here are my comments.
usr/src/cmd/apache2/modules/apxs-sed.ksh93 :
What is "LIBP" used for ?
usr/src/cmd/apache2/modules/sed.mk :
Do you really need this line ?
find $(SED_VER)-$* -type d -exec chmod go+rx {} +
I don't see any directories within mod_sed-* .
usr/src/pkgdefs/SUNWapch22r-sed/Makefile ,
usr/src/pkgdefs/SUNWapch22r-sed/prototype_com :
"renamenew" class action script is used only for configurations in conf.d
directory.
Some formatting nits:
usr/src/pkgdefs/SUNWapch22m-sed/Makefile ,
usr/src/pkgdefs/SUNWapch22r-sed/Makefile :
Move indent line below Copyright information.
usr/src/pkgdefs/SUNWapch22m-sed/depend , usr/src/pkgdefs/SUNWapch22r-sed/depend
:
Include Copyright information after the CDDL header.
Regards,
Seema.
On 03/06/09 08:52, Basant Kumar kukreja wrote:
> Hi,
> Please review the webrev for mod_sed integration into sfw.
> http://cr.opensolaris.org/~basantk/6715145/webrev/
>
> mod_sed is the Sun's donated apache module. It was originally developed for
> apache 2.2. It has been checked into the apache trunk. There is no version
> number associated with it. It will be builtin module for future apache
> revisions (2.4).
>
> Metadata file contains the OSR number and other information.
> http://cr.opensolaris.org/~basantk/6715145/webrev/raw_files/new/usr/src/cmd/apache2/modules/METADATA.sed
>
> ARC Case : PSARC/2007/586
>
> Kindly review,
>
> Thanks,
> Basant.
>
>
> _______________________________________________
>
>
> webstack-discuss mailing list
> webstack-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
