On 03/06/09 14:01, Basant Kukreja wrote:
> Thanks Seema for providing the comments.
>
> On Fri, Mar 06, 2009 at 12:13:27PM +0530, Seema Alevoor wrote:
>> Hi Basant,
>>
>> Here are my comments.
>>
>> usr/src/cmd/apache2/modules/apxs-sed.ksh93 :
>> What is "LIBP" used for ?
> Fixed and updated the webrev.
>
But that still looks incomplete.
LIBS is set to nil, then why pass LIBS to apxs ?
>> usr/src/cmd/apache2/modules/sed.mk :
>> Do you really need this line ?
>> find $(SED_VER)-$* -type d -exec chmod go+rx {} +
>> I don't see any directories within mod_sed-* .
> Fixed and updated the webrev.
>
Fine.
>> usr/src/pkgdefs/SUNWapch22r-sed/Makefile ,
>> usr/src/pkgdefs/SUNWapch22r-sed/prototype_com :
>> "renamenew" class action script is used only for configurations in
>> conf.d directory.
> Can you elaborate? I took the similar approach as SUNWapch22r-security2.
>
>>
>> Some formatting nits:
>>
>> usr/src/pkgdefs/SUNWapch22m-sed/Makefile ,
>> usr/src/pkgdefs/SUNWapch22r-sed/Makefile :
>> Move indent line below Copyright information.
> Fixed and updated the webrev.
usr/src/pkgdefs/SUNWapch22r-sed/Makefile still has ident line above copyright
info.
-- Seema.
>> usr/src/pkgdefs/SUNWapch22m-sed/depend ,
>> usr/src/pkgdefs/SUNWapch22r-sed/depend :
>> Include Copyright information after the CDDL header.
> Can you elaborate? SUNWapch22r/depend SUNWphp52r/depend all looks similar to
> the sed ones. Copyright information appears before CDDL header. Can you point
> me to the correct one?
>
> Regards,
> Basant.
>>
>> Regards,
>> Seema.
>>
>>
>> On 03/06/09 08:52, Basant Kumar kukreja wrote:
>>> Hi,
>>> Please review the webrev for mod_sed integration into sfw.
>>> http://cr.opensolaris.org/~basantk/6715145/webrev/
>>>
>>> mod_sed is the Sun's donated apache module. It was originally developed for
>>> apache 2.2. It has been checked into the apache trunk. There is no version
>>> number associated with it. It will be builtin module for future apache
>>> revisions (2.4).
>>>
>>> Metadata file contains the OSR number and other information.
>>> http://cr.opensolaris.org/~basantk/6715145/webrev/raw_files/new/usr/src/cmd/apache2/modules/METADATA.sed
>>>
>>> ARC Case : PSARC/2007/586
>>>
>>> Kindly review,
>>>
>>> Thanks,
>>> Basant.
>>>
>>> _______________________________________________
>>>
>>>
>>> webstack-discuss mailing list
>>> webstack-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
