Looks ok but with a few comments:

usr/src/cmd/mysql-5-1/METADATA

- You might want to look at Norm's update to the METADATA guidelines at 
http://wikis.sun.com/display/SFWNotes/METADATA They seem to be using a 
single letter in the Support field now.

usr/src/cmd/mysql-5-1/Makefile.sfw

- Why all of the touching of files and the sleep statements? It's hard 
to see what this achieves aside from adding 20-odd seconds to the build 
time.

usr/src/pkgdefs/SUNWmysql51test/prototype_com

  - What happened to all of the tests that are being removed? Are they 
no longer included in the MySQL distribution?

Thanks

Amanda

On 14/12/2009 11:46, sunanda menon wrote:
> Hi,
>
> Please review the code changes for mysql-5.1.37 upgrade at 
> http://cr.opensolaris.org/~sunandam/6857014/
>
> Let me know your comments.
>
> Thanks Sunanda
>

Reply via email to