sunanda menon wrote: > Jeff Trawick wrote: >> sunanda menon wrote: >>> Please review >>> >>> sunanda menon wrote: >>>> Hi, >>>> >>>> Please review the code changes for mysql-5.1.37 upgrade at >>>> http://cr.opensolaris.org/~sunandam/6857014/ >>>> >>>> Let me know your comments. >> >> Why do we need *usr/src/cmd/mysql-5-1/patches/xO4_optimization.patch? >> Isn't optimization reduced to -O2 for all of MySQL? >> * > No not for all of mysql.We have found a solution and that means if we > have this patch then all of mysql stays at xO4 except the > prev_record_reads function which as per the mysql bug #49091 has been > reduced to -O2.
Glad to hear it! But in Makefile.sfw I see these changes, hence my confusion: # C++ common flags -CXXCOMMONFLAGS= -DDBUG_OFF -DBIG_TABLES -DHAVE_RWLOCK_T -KPIC -DPIC -xO4 \ +CXXCOMMONFLAGS= -DDBUG_OFF -DBIG_TABLES -DHAVE_RWLOCK_T -KPIC -DPIC -xO2 \ -xprefetch=auto -xprefetch_level=3 -mt -fns=no -fsimple=1 -xbuiltin=%all \ -xlibmil -xlibmopt -norunpath @@ -56,7 +56,7 @@ CXX32FLAGS= $(CXXCOMMONFLAGS) # C common compiler flags -COMMONCFLAGS= -xO4 -xstrconst -xprefetch=auto -xprefetch_level=3 -mt\ +COMMONCFLAGS= -xO2 -xstrconst -xprefetch=auto -xprefetch_level=3 -mt\ Do those changes now need to be backed out of Makefile.sfw?
