On 16/12/2009 11:22, sunanda menon wrote: > Amanda Waite wrote: >> Looks ok but with a few comments: >> >> usr/src/cmd/mysql-5-1/METADATA >> >> - You might want to look at Norm's update to the METADATA guidelines >> at http://wikis.sun.com/display/SFWNotes/METADATA They seem to be >> using a single letter in the Support field now. > > I'll take a look at this and correct.Thanks >> >> usr/src/cmd/mysql-5-1/Makefile.sfw >> >> - Why all of the touching of files and the sleep statements? It's >> hard to see what this achieves aside from adding 20-odd seconds to >> the build time. > > > Since we are patching the mysql-5.1.37 source base ,some files gets > modified like the Makefile.am,configure.in and other input files which > causes an automatic rerun of the GNU autotools and which caused the > nightly builds to fail with messages such as posted earlier in this forum > > ==== Build errors (non-DEBUG) ==== > > aclocal.m4:14: error: this file was generated for autoconf 2.61. > aclocal.m4:14: error: this file was generated for autoconf 2.61. > > > ==== Elapsed build time (non-DEBUG) ==== > > By doing these changes,we are just avoiding retrigger runs of GNU > autotools.
And why the 'sleep 5's? that was my biggest concern, if you need to sleep to make it all work then why? Is there some issue with parallel make? Did you hit some kind of race condition? Sleeps are never a good way to avoid that kind of issue. Amanda > >> >> usr/src/pkgdefs/SUNWmysql51test/prototype_com >> >> - What happened to all of the tests that are being removed? Are they >> no longer included in the MySQL distribution? > > yes some tests gets added or modified and some deprecated with every > mysql version changes. >> >> Thanks >> >> Amanda >> >> On 14/12/2009 11:46, sunanda menon wrote: >>> Hi, >>> >>> Please review the code changes for mysql-5.1.37 upgrade at >>> http://cr.opensolaris.org/~sunandam/6857014/ >>> >>> Let me know your comments. >>> >>> Thanks Sunanda >>> >> > >
