Update of patch #1549 (project wesnoth):
Status: Postponed => Wont Do
_______________________________________________________
Follow-up Comment #7:
Sorry, but the patch is full of completely weird and confusing macro usage
for absolutely no reason. Also a lot of comments have disappeared, even
common and obvious shortcut macros like MODIFY_TERRAIN or PLAY_SOUND are now
expanded and most of the added help texts are grammatically broken.
All in all, it might be an improvement over the old version or it might not
be. It's a huge patch, I can see problems like the above all over the place
and I can't read through it all and diffing isn't of any help since the
changes are so huge.
So, I'll mark this as "won't do" for now since it's still not quite the
quality we need in mainline (that is, while this might be better than the old
version, this is now more a question of whether it's good enough to warrant
keeping ANL in mainline at all). Of course anyone's welcome to fix the patch,
at which point I can take another look at it.
I'm attaching the version I ended up with by randomly fixing problems I found
in the patch, just in case someone's interested. I don't know how much there
is still left to do, neither have I tested it in-game at all.
(file #8896)
_______________________________________________________
Additional Item Attachment:
File name: 4p_A_New_Land.cfg Size:182 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1549>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
