URL:
<http://gna.org/patch/?3005>
Summary: Replay buttons fix, resolves bug #18892
Project: Battle for Wesnoth
Submitted by: moloch
Submitted on: mer 02 nov 2011 13:49:52 GMT
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
Solves bug #18892 <https://gna.org/bugs/?18892>.
I tested it on many replays and switching line 262 and line 263
in replay_controller.cpp avoids the segfault.
replay_controller::update_gui() contains a call to the draw method
(*gui_).draw();
Inside that method there's a call to display::draw_init(), which contains a
call to display::draw_all_panels().
Inside that call there's a call to display::create_buttons()
Inside that method the button objects are created: trying to invoke
buttons_.update(gui_) before doing an update_gui() ends up with the segfault
which is causing the problem.
I'm eventually sorry for my poor explanation and the (maybe) dirty fix, I'm
new here... :)
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: mer 02 nov 2011 13:49:52 GMT Name: replay_buttons_fix.patch Size: 1kB
By: moloch
<http://gna.org/patch/download.php?file_id=14388>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3005>
_______________________________________________
Messaggio inviato con/da Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
