hey gabriel
I will gladly review your patch but i'm away from my main computer
until next week, so don't hold your breath
to answer about translation, we usually avoid that because it messes
up the way transaltion maintainers (as a mater of fact, Noyga, the
french maintainer is on this ML so he can answer for french
specificities himself)
thx for the nice feature
Boucman
On Sun, Mar 14, 2010 at 6:11 AM, Gabriel Morin <gabrielmo...@gmail.com> wrote:
> To answer my own question, it probably won't go in before 1.8 since it would
> force every translator to translate my button and dialog. I was thinking
> about the feature freeze but forgot about the string freeze.
>
> On this topic, I'd like to know if gettext strings of the type _("An English
> String") automatically get extracted from the source code for translators to
> look at, or do we have to manually add them somewhere?
>
> Also, can we submit translations of such strings to the languages we know
> well as part of a patch? I know I could at least add my strings to fr.po,
> it'd save the translator some work.
>
> 2010/3/13 Gabriel Morin <gabrielmo...@gmail.com>
>>
>> Ok, I've coded up something: https://gna.org/patch/index.php?1528
>> Boucman, I'd be honored if you could take a look.
>> The patch is very small, but in summary, I added a button to add named
>> local players, and left the possibility to put an anonymous one.
>> I don't create a new player if a similar named one already exists.
>>
>> I tested it pretty heavily in a network game and a local game, in english
>> and in french. Saving and loading works as well... don't think I broke
>> anything :) .
>>
>> Since is more a solution to a bug than a feature, is there any chance this
>> could get in before 1.8? Right now hot-seat looks pretty bad with all the
>> dialog between "Anonymous Local Player" and his alter ego.
>>
>> And thanks YogiHH for the tip, it helped.
>>
>> Gabba
>>
>> 2010/3/13 Jörg Hinrichs <joerg.hinri...@alice-dsl.de>
>>>
>>> I guess multiplayer_connect.cpp is what you are looking for.
>>>
>>> Greetings
>>>
>>> YogiHH
>>>
>>>
>>>
>>> ________________________________
>>>
>>> Von: wesnoth-dev-boun...@gna.org [mailto:wesnoth-dev-boun...@gna.org] Im
>>> Auftrag von Gabriel Morin
>>> Gesendet: Samstag, 13. März 2010 06:56
>>> An: dev-talk
>>> Betreff: Re: [Wesnoth-dev] Allow renaming hotseat players to something
>>> elsethan "Anonymous Local Player"
>>>
>>>
>>>
>>> A pointer to the right classes would be appreciated, those that I need to
>>> use to:
>>> 1- Add a text field to the hotseat screen where you pick your sides and
>>> leader
>>> 2- Actually change the players'/sides'/leaders' names
>>>
>>> If I actually don't do it myself I'll pass on those hints when I make the
>>> EasyCoding entry.
>>>
>>>
>>>
>>> 2010/3/11 jeremy rosen <jeremy.ro...@enst-bretagne.fr>
>>>
>>> you should indeed do a FR on gna, since I don't think ther's much to
>>> discuss here... it's a good idea, go for it, or add it to EasyCoding
>>> :P
>>>
>>> On Thu, Mar 11, 2010 at 1:07 AM, Gabriel Morin <gabrielmo...@gmail.com>
>>> wrote:
>>> > I should probably create a bug or a feature request on Gna!, but
>>> > mentioning
>>> > it here is easier to start with.
>>> >
>>> > When playing hotseat, all human players except the first one are
>>> > automatically named "Anonymous Local Player". This really looks bad
>>> > since
>>> > in-game their leaders all get that name, and it can get confusing. It
>>> > also
>>> > messes up dialogs, since you get "Anonymous Local Player" talking to
>>> > "Anonymous Local Player".
>>> >
>>> > Can we please allow hotseat players to enter their name?
>>> >
>>> > Hopefully it's trivial to fix and someone got to it at the very moment
>>> > they
>>> > saw this message; otherwise would it be appropriate to add to the wiki
>>> > as an
>>> > EasyCoding task?
>>> >
>>> > Regards,
>>> > Gabba
>>> >
>>>
>>> > _______________________________________________
>>> > Wesnoth-dev mailing list
>>> > Wesnoth-dev@gna.org
>>> > https://mail.gna.org/listinfo/wesnoth-dev
>>> >
>>> >
>>>
>>> _______________________________________________
>>> Wesnoth-dev mailing list
>>> Wesnoth-dev@gna.org
>>> https://mail.gna.org/listinfo/wesnoth-dev
>>>
>>>
>>>
>>> _______________________________________________
>>> Wesnoth-dev mailing list
>>> Wesnoth-dev@gna.org
>>> https://mail.gna.org/listinfo/wesnoth-dev
>>>
>>
>
>
> _______________________________________________
> Wesnoth-dev mailing list
> Wesnoth-dev@gna.org
> https://mail.gna.org/listinfo/wesnoth-dev
>
>
_______________________________________________
Wesnoth-dev mailing list
Wesnoth-dev@gna.org
https://mail.gna.org/listinfo/wesnoth-dev
