[ 
https://issues.apache.org/jira/browse/WHIRR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972225#action_12972225
 ] 

Tom White commented on WHIRR-161:
---------------------------------

* Apache James uses not-yet-commons-ssl, so there's a precedent 
(http://svn.apache.org/viewvc/james/jdkim/trunk/pom.xml?view=markup).
* Can you use Apache Commons Codec for the Base64 encoding? 
http://commons.apache.org/codec/apidocs/org/apache/commons/codec/binary/Base64.html
* Does this code only support RSA keys? Should we generalize to support DSA 
keys too? Or at least update the docs to spell out what is supported (I would 
suggest a note in src/site/confluence/quick-start-guide.confluence). 
* Nits: the indentation should be two spaces, and star imports should be 
avoided.

> Check that both SSH keys belong to the same pair
> ------------------------------------------------
>
>                 Key: WHIRR-161
>                 URL: https://issues.apache.org/jira/browse/WHIRR-161
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-161.patch
>
>
> Check that the private and public keys belong to the same pair (via, e.g. 
> http://s.apache.org/MNY or by en/decrypting a dummy message). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to