[
https://issues.apache.org/jira/browse/WHIRR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972315#action_12972315
]
Andrei Savu commented on WHIRR-161:
-----------------------------------
I will change the patch to use commons-codec for Base64 encoding.
> Does this code only support RSA keys? Should we generalize to support DSA
> keys too?
It supports only RSA keys but this limitation was already in the code base.
Should we keep things the way they are? I will add a note to confluence
explaining the restriction.
> Nits: the indentation should be two spaces, and star imports should be
> avoided.
Ok. I will fix that.
> Check that both SSH keys belong to the same pair
> ------------------------------------------------
>
> Key: WHIRR-161
> URL: https://issues.apache.org/jira/browse/WHIRR-161
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.3.0
>
> Attachments: WHIRR-161.patch
>
>
> Check that the private and public keys belong to the same pair (via, e.g.
> http://s.apache.org/MNY or by en/decrypting a dummy message).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
