[ 
https://issues.apache.org/jira/browse/WHIRR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973408#action_12973408
 ] 

Tom White commented on WHIRR-161:
---------------------------------

Thanks for the new patch. It's getting close now.

* KeyPair#sameKeyPair swallows the exception. We should at least log it.
* KeyPairTest should use assertThat rather than assert (since the latter 
depends on whether asserts are enabled).
* The indentation and start import still need fixing.

Have you manually tested this with a keypair generated with ssh-keygen?

+1 to moving DSA key support to another issue.


> Check that both SSH keys belong to the same pair
> ------------------------------------------------
>
>                 Key: WHIRR-161
>                 URL: https://issues.apache.org/jira/browse/WHIRR-161
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-161.patch, WHIRR-161.patch
>
>
> Check that the private and public keys belong to the same pair (via, e.g. 
> http://s.apache.org/MNY or by en/decrypting a dummy message). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to