Eelco Hillenius wrote:
I've given this thread a little bit thought, and besides the
objections Martijn and me have regarding the book, I don't think I
like SubmitButton better than Button. To me, a Button is more generic
and SubmitButton makes me think about 'just' the <input type="submit">
tag while it can be used for more than that (which is something I
always liked). Just a personal preference, sure, but also an
indication to me that we might like SubmitButton today, Button
tomorrow, and they day after (maybe with other people in the team)
SubmitButton again. At some point we'll just have to say, this is ok,
even if not everyone completely agrees at any given time. Naming is
important, but so is stability.
Yeah, I agree. ;-)
The real issue here is with predictability and consistency. I expect the
AJAX version of component Foo to be called AjaxFoo, and with the button
stuff, it wasn't.
So either we change AjaxSubmitButton to be AjaxButton, or change Button
to be SubmitButton, otherwise it's just really confusing.
Button is definitely used more heavily than AjaxSubmitButton, so the
former change has the least impact, which is why I've just implemented it.
The only argument for SubmitButton is that it's consistent with
SubmitLink. That said, you can always argue SubmitLink is oddly named,
as there's really no such thing in the HTML spec, and it should be
called JavascriptSubmitLink instead. ;-)
Swings. Roundabouts.
I think we're done with this now...
Al
--
Alastair Maw
Wicket-biased blog at http://herebebeasties.com
