so you always want to call getConverter() and if typename is not set you get a null param? and then all the components that now implemements convertValue(String[] values) should override getConverted(Class) and test for null and if it is null then return a converter which does the same as convertValue does now.
we could do that yes. It cleans up the api and makes it more obvious that getConverter() is always called. johan On 7/11/07, Al Maw <[EMAIL PROTECTED]> wrote:
Al Maw wrote: > In my opinion, if you override getConverter() then it should always be > used, even if that means we have to call it with a null type parameter. > (Normally when you're overriding it for a particular component you don't > care about the type parameter anyway). Looking at this further, it seems logical to me that we should remove the convertValue(String[] value) method from FormComponent and push the logic in there into a "proper" converter, which gets registered for null types. Thoughts? Regards, Al -- Alastair Maw Wicket-biased blog at http://herebebeasties.com
