daniel added a comment.
> I also notice that MediaWiki core has again hard-deprecated code that is still used in Wikimedia-maintained code even though the stable interface policy forbids this This was of course not intentional - the policy asks for hard deprecation to happen as soon as all callers have been fixed. Which of course in practice means as soon as we //think// all callers have been fixed. The problem is that it's sometimes hard to find such code - and sometimes it's only found when it starts logging deprecation warnings in production. > That's not a valid reason to bypass the deprecation policy. In the past we just added logging for it (e.g. T176526 <https://phabricator.wikimedia.org/T176526>: Remove $wgTitle fallback from EditPage in MW1.36) until we were satisfied we had caught everything. Technically, deprecation warnings //are// logging. I can see that it would be preferable to start out with a lower log level, so these don't show up as production errors. But using "soft" logging means these issues don't show up as test failures. The fact that deprecation warnings make tests fail is very helpful for finding any cases we missed by looking at the code. Perhaps the solution is to handle deprecation warnings separate from other production issues? Anyway, the "proper" fix done, I'll clean up the remaining issues in the tests tomorrow: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/672499 TASK DETAIL https://phabricator.wikimedia.org/T277362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: dancy, Legoktm, RhinosF1, brennen, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, daniel, WMDE-leszek, toan, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, AMooney
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
