Legoktm added a comment.
In T277362#6919814 <https://phabricator.wikimedia.org/T277362#6919814>, @daniel wrote: >> That's not a valid reason to bypass the deprecation policy. In the past we just added logging for it (e.g. T176526 <https://phabricator.wikimedia.org/T176526>: Remove $wgTitle fallback from EditPage in MW1.36) until we were satisfied we had caught everything. > > Technically, deprecation warnings //are// logging. I can see that it would be preferable to start out with a lower log level, so these don't show up as production errors. But using "soft" logging means these issues don't show up as test failures. The fact that deprecation warnings make tests fail is very helpful for finding any cases we missed by looking at the code. It just pushes the problem onto someone else, by stopping their development and forcing them drop everything just to unbreak their repo - in this case it hit everyone by stopping the entire train. That Wikimedia-deployed code was still using this hard deprecated code was identified on Saturday, once that identification was done, why did it have to rise all the way to a train blocker on Tuesday to get a revert? TASK DETAIL https://phabricator.wikimedia.org/T277362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Legoktm Cc: dancy, Legoktm, RhinosF1, brennen, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, daniel, WMDE-leszek, toan, Aklapper, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs