daniel added a comment.
In T277362#6919927 <https://phabricator.wikimedia.org/T277362#6919927>, @Legoktm wrote: > It just pushes the problem onto someone else, by stopping their development and forcing them drop everything just to unbreak their repo I was not aware this broke any tests in any repo - did it? My understanding was that there are no automated tests for the cross-wiki case in Wikibase. Because there are no such tests, the issue did not show up in CI. I have been wanting to improve this situation for quite a while. Perhaps incidents like this one can help to explain why we need to improve our testing platform. Some relevant tickets: T261848: Simulate databases for sister sites in phpunit <https://phabricator.wikimedia.org/T261848>, T248683: Create and run a suite of end-to-end tests for the Wikimedia environment <https://phabricator.wikimedia.org/T248683>, T195932: Test all MediaWiki tarball extensions in gate for all changes to MediaWiki and each other <https://phabricator.wikimedia.org/T195932>. > - in this case it hit everyone by stopping the entire train. I don't see why deprecation warnings should stop the train at all. I agree that they should be worked on with high priority, but why should they be treated as production errors? > That Wikimedia-deployed code was still using this hard deprecated code was identified on Saturday, once that identification was done, why did it have to rise all the way to a train blocker on Tuesday to get a revert? I learned about the issue from Hoo on IRC at 17:30 on Monday. I immediately started work on a fix. On Tuesday, that fix got a couple of rounds of review, getting the tests right wasn't trivial. However, the urgency wasn't clear at all, I didn't hear from the wikidata team all day. TASK DETAIL https://phabricator.wikimedia.org/T277362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, daniel Cc: dancy, Legoktm, RhinosF1, brennen, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, daniel, WMDE-leszek, toan, Aklapper, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
