On 06/01/2011 08:28 AM, Chad wrote: > I don't think "revert in 72 hours if its unreviewed" is a good idea. It > just discourages people from contributing to areas in which we only > have one reviewer looking at code. > > I *do* think we should enforce a 48hr "revert if broken" rule. If you > can't be bothered to clean up your breakages in within 48 hours of > putting your original patch in, it must not have been very important. > > -Chad I think a revert on sight, if broken is fair ... you can always re-add it in after you fix it ... if its a 'works diffrently than expected' type issue / not perfectly following coding conventions a 48hr window to make progress ( during the work week ) sounds reasonable.
--michael _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
