User "Raindrift" posted a comment on MediaWiki.r92009. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92009#c19560 Commit summary:
Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179 Tweaked the UploadWizard to work properly with the new backend code, updated tests Comment: Thanks for the info. I'm now pulling user info from ApiBase::createContext (though if it's truly deprecated, [[Manual:$wgUser]] should probably be updated). I'm still using $wgUser when called from Filerepo::getUploadStash, since Filerepo doesn't seem to be aware of the current user. I went ahead and changed the type of us_media_type for consistency... I figure if it ever changes to a not-enum, it won't be hard to do it in both places. Timestamp generation is corrected (and I'm glad to see the move to a function that might make datetime columns possible someday). However, [[Manual:WfTimestamp]] should probably mention that this is the right way to do things. I'd make the documentation changes myself, but I'm still a bit unsure about what the correct conventions are at this point. Updates are in r92081 _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
