"Hashar" posted a comment on MediaWiki.r111085.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111085#c30959
Commit summary for MediaWiki.r111085:
(bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist.
Now titles are fixed or deleted, if unfixable, upon loading
Special:EditWatchlist.
Hashar's comment:
if ( $this->checkTitle( $title, $row->wl_namespace, $row->wl_title )
+ && !$title->isTalkPage()
+ ) {
That isTalkPage should probably be part of the checkTitle() method.
User->cleanupWatchlist() should be properly deprecated for back compatibility
(it is a public function).
A new class property probably deserve a new comment :-)
+ private $badItems = array();
In cleanupWatchlist() the foreach on badTitle seems to be inserting those bad
titles back in the DB:
if ( $title ) {
+ $this->getUser()->addWatch( $title );
+ }
_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
