"MaxSem" posted a comment on MediaWiki.r111085. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111085#c30962
Commit summary for MediaWiki.r111085: (bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist. Now titles are fixed or deleted, if unfixable, upon loading Special:EditWatchlist. MaxSem's comment: > User->cleanupWatchlist() should be properly deprecated for back compatibility > (it is a public function). But it had no callers whatsoever save this code that was there just for one version. > In cleanupWatchlist() the foreach on badTitle seems to be inserting those bad > titles back in the DB This code path is for updating of titles normalised by Title::secureAndSplit(), what's your definition of 'bad'? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
