"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31004
Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intranet, this is ignored in (Curl)HttpRequest because the proxy url is not cleared. This commit makes sure at lowest level - namel in the public function proxySetup() - that a optional(true) value of noProxy is observed and that it (now) also clears the proxy url. (I have been told that I am allowed to commit this patch. Please carefully review, as usual). Wikinaut's comment: (background: I found this problem when debugging Extension:RSS for fetching feeds from external servers using a proxy and from internal domains w/o proxy. E:RSS uses HttpRequest classes . It was however _not_ possible to fetch feeds from internal domains - where no proxy is allowed - even when setting noProxy = true as it was documented. Debugging then inside HttpRequst revealed, that the proxy url came through, but the noProyx switch value was lost - before curl was executed. Curl tried to fetch an internal url with proyx - which failed.) _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
