On 2015-01-29 1:14 PM, Jon Robson wrote: > Thanks for kicking off the conversation Brad :-) > > Just mean at the moment. I hacked together and I'm more than happy to > iterate on this and improve the reporting. > > On the subject of patch abandonment: Personally I think we should be > abandoning inactive patches. They cause unnecessary confusion to > someone coming into a new extension wanting to help out. We may want > to change the name to 'abandon' to 'remove from code review queue' as > abandon sounds rather nasty and that's not at all what it actually > does - any abandoned patch can be restored at any time if necessary. Unfortunately, under Gerrit, abandoning a patch puts "inactive, restore if you can finish it" patches in the same bin as "this was a complete failure".
Not only do you have to examine each abandoned patch individually to see if it's worth reopening, but after they leave your recently closed list they are all segregated to an obscure place not everyone knows how to get to (you have to manually search for "owner:self status:abandoned"). Proper handling of 'remove from code review queue' abandonment should include a section on a user's dashboard listing patches that have been removed from the queue due to inactivity, etc... but not outright rejected. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
