Carlos R. Mafra wrote: > On Sun 9.Nov'08 at 12:28:53 -0800, John H. Robinson, IV wrote: > > Carlos R. Mafra wrote: > > > > > > It would be really odd if the output of 'hg log' doesn't > > > show you unambigously who the author is, don't you agree? > > > > hg log -v will show you the complete log, instead of just the headers. > > hg annotate uses the user: field when showing who is responsible for > > what line. > > No, no, this is not sensible at all.
I am going to disagree with you. > One should not have to _search_ the commit log to know who the author of > a patch is. This is the kind of information which should be really obvious > from just looking at 'hg log'. > > You just forgot to add --user="true author" when you commited those > patches, imo. There was no forgetting. The information is in the commit log. Where it should be. The user is committer in this case. > Take a look at this commit here: > > http://hg.windowmaker.info/wmaker/rev/8640d186c4f4 > > and now tell me what you read as the 'author' field on the header. > > That is clearly wrong. Misleading, yes, but I believe that is fixable. Take a look now, and the instances of Author in the header have been replaced with the more correct Committer. > And it is pointless to require someone to 'fix' mentally this error > _after_ reading the commit log. That simply does not make sense. > > > This follows the CVS convention that had been in use for a very long > > time. > > We don't have to repeat this confusion now that we have better tools. We don't have to sow the confusion as to who is making the commit. Git has a concept of both Author and Committer. Mercurial does not. The question is if ``user'' is the committer or the author. I see it as the committer. > To make things clear, I am not accusing you of improper authorship handling. > I just wanted to point out that maybe you are not 'driving' Mercurial > correctly yet :-) Perhaps we should come up with a standardised commit log format that clearly shows who authored each patch as well as what it is for. -- John H. Robinson, IV [EMAIL PROTECTED] http (((( WARNING: I cannot be held responsible for the above, sbih.org ( )(:[ as apparently my cats have learned how to type. spiders.html (((( -- To unsubscribe, send mail to [EMAIL PROTECTED]
