> I recompiled my WM Debian package with the patch appended to this
> mail which is of course not more than a workaround but it at least
> keeps WM from crashing.

I assume the wmaker from the mercurial repo here

http://hg.windowmaker.info/wmaker/

also crashes, right?

> If my assumption is true, and X11 fails to handle such windows
> properly I would very much assume that the above crash is really
> only the tip of the iceberg, thus a bit more of checking and
> fixing will be necessary.

Do you have any other test case where this bug appears?

I tried to install Safari for Windows here using Wine to try
to reproduce your problem, but Safari dies before opening
any window.

  
> -    ChangeStackingLevel(wwin->frame->core, layer);
> -    wwin->frame->flags.need_texture_change = 1;
> -    wWindowConfigureBorders(wwin);
> -    wFrameWindowPaint(wwin->frame);
> +    /* wwin-frame may be null here, thus first: avoid crash */
> +    if (wwin->frame != NULL) {

This bug has to be investigated further, but it never hurts to
be defensive and check for 'NULL' when things can go wrong.
But I would also use wwarning() to let people know that this
was not supposed to happen.

> +        ChangeStackingLevel(wwin->frame->core, layer);
> +        wwin->frame->flags.need_texture_change = 1;
> +        wWindowConfigureBorders(wwin);
> +        wFrameWindowPaint(wwin->frame);
> +    }
>      wNETWMUpdateActions(wwin, False);
>  }
>  


-- 
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to