Rodolfo García Peñas <[email protected]> writes:

Hi Rodolfo:

> IMO, we should vote to include or not some patches.

IMHO, since a lot of people that use GNUstep also use Window Maker, this
should be included. Here is a patch.

Regards,
Charles

From 68d9141d03eb88019f41c2d19e71a2611f21ad82 Mon Sep 17 00:00:00 2001
From: Charles Philip Chan <[email protected]>
Date: Tue, 10 Sep 2013 17:49:37 -0400
Subject: [PATCH] Make the balloon help of GNUstep apps' appicons show the app name
 instead of GNUstep.

---
 src/balloon.c |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/src/balloon.c b/src/balloon.c
index e2c294a..fbe8807 100644
--- a/src/balloon.c
+++ b/src/balloon.c
@@ -447,14 +447,27 @@ static void appiconBalloon(WObjDescriptor * object)
 			return;
 		}
 	} else if (aicon->command && aicon->wm_class) {
-		int len = strlen(aicon->command) + strlen(aicon->wm_class) + 8;
+		int len;
+                /* Check to see if it is a GNUstep app */ 
+		if (strcmp(aicon->wm_class,"GNUstep") == 0)
+			len = strlen(aicon->command) + strlen(aicon->wm_instance) + 8;
+		else 
+			len = strlen(aicon->command) + strlen(aicon->wm_class) + 8;
 		tmp = wmalloc(len);
-		snprintf(tmp, len, "%s\n(%s)", aicon->wm_class, aicon->command);
+                /* Check to see if it is a GNUstep App */
+		if (strcmp(aicon->wm_class,"GNUstep") == 0)
+			snprintf(tmp, len, "%s\n(%s)", aicon->wm_instance, aicon->command);
+		else
+			snprintf(tmp, len, "%s\n(%s)", aicon->wm_class, aicon->command);
 		scr->balloon->text = tmp;
 	} else if (aicon->command) {
 		scr->balloon->text = wstrdup(aicon->command);
 	} else if (aicon->wm_class) {
-		scr->balloon->text = wstrdup(aicon->wm_class);
+                /* Check to see if it is a GNUstep App */ 
+		if (strcmp(aicon->wm_class,"GNUstep") == 0)
+			scr->balloon->text = wstrdup(aicon->wm_instance);
+		else
+			scr->balloon->text = wstrdup(aicon->wm_class);
 	} else {
 		wBalloonHide(scr);
 		return;
-- 
1.7.3.4

-- 
"The IETF motto is 'rough consensus and running code'"
  
  -- Scott Bradner (Open Sources, 1999 O'Reilly and Associates)

Attachment: signature.asc
Description: PGP signature

Reply via email to