On Fri, 25 Jan 2013, BALATON Zoltan escribió:
> On Fri, 25 Jan 2013, Carlos R. Mafra wrote:
> >On Fri, 25 Jan 2013 at 1:06:58 +0100, Rodolfo García Peñas wrote:
> >>I changed the behavior for the winspector. Can you test it now?
> >>
> >>More testers are welcome. If the patch is ok, I will write the commit info.
> >
> >I'm a bit lost about which behavior is being fixed. What is the test
> >case to aim for?
> >
> >On the other hand, if Zoltan says it fixes his issues, I'll apply
> >without testing it myself :-)
>
> I don't have time to test it now but I've described the problem,
> testing procedure and provided a test case in the thread starting at
>
> http://lists.windowmaker.org/dev/msg04395.html
>
> The test case is here:
> http://lists.windowmaker.org/dev/msg04396.html
> (Should show a white rectangle in the app icon which is the icon window.)
>
> The procedure to test Ignore app icon is here:
> http://lists.windowmaker.org/dev/msg04452.html
>
> Hope this helps.
>
> Regards,
> BALATON Zoltan
Hi Zoltan,
about this problem, after some tests, I think the right code is:
--------8<-----------
kix@kentin:~/src/wmaker/git/wmaker-crm/src$ git diff
diff --git a/src/icon.c b/src/icon.c
index 1a23b88..fdc377d 100644
--- a/src/icon.c
+++ b/src/icon.c
@@ -126,8 +126,6 @@ WIcon *icon_create_for_wwindow(WWindow *wwin)
wapp = wApplicationOf(wwin->client_win);
if (!wapp || wapp->app_icon == NULL)
icon->icon_win = wwin->wm_hints->icon_window;
- } else {
- icon->icon_win = wwin->wm_hints->icon_window;
}
}
#ifdef NO_MINIWINDOW_TITLES
--------8<-----------
It runs with the wmicontest application, and run with xfig. Xfig can now use
the user icon, or the client icon. What do you think?
kix
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
