On Sat, 26 Jan 2013 at 11:12:01 +0100, "Rodolfo García Peñas (kix)" wrote:
Thanks for the detailed explanation. > On 25/01/2013 11:53, BALATON Zoltan wrote: > > > > The procedure to test Ignore app icon is here: > > http://lists.windowmaker.org/dev/msg04452.html > I am changing the icon behavior in winspector.c, these cases: > > 1. ignore flag + file set > 2. no ignore flag + file set > 3. ignore flag + no file set > 4. no ignore flag + no file set > > I didn't change the xfig related problem. Zoltan's test scenario has a lot of things to watch... > The problem is if the user try to set an icon (ignore flag is set) but the > file textbox is not set (no icon provided). Now the code does: > > 1. Show a message box to the user with a warning. The warning show: > > + snprintf(buf, len, _("Ignore client supplied icon is > set, but icon filename textbox is empty. Using client supplied icon")); > > 2. Unset the "ignore flag" and use the client provided icon. Is like we > change the case 3 to case 4: This change looks correct to me. I'll apply your patch and do some copy & paste from your explanation above as the commit message. Thanks a lot for keeping track of this. -- To unsubscribe, send mail to [email protected].
